Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update classifiers stating Python versions #241

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

EliahKagan
Copy link
Contributor

@EliahKagan EliahKagan commented Aug 14, 2023

This updates the classifiers listed in setup.py.

Removals:

  • Python 2 classifiers. Although a significant amount of the code remains written in the common subset of Python 2 and Python 3, the codebase overall no longer supports Python 2. For example, collections.abc is imported.
  • Python 3.5. Not all tests reliably pass. Specifically, test_regression_208 sometimes passes and sometimes raises TypeError. Later versions do not show such nondeterministic behavior, even when the test is run many times in succession (it always passes).
  • Python 3.6. Tests still pass. This version does appear still to work. However, 3.6 has been unsupported by the PSF for a significant time, and it is no longer tested in tox.ini or in the CI test workflow.

Additions: 3.8, 3.9, 3.10, and 3.11. (Along with 3.7, which was already listed, these are the actual supported versions. These versions are tested regularly on CI, with all tests passing.)

While editing the classifiers, I also removed some unused imports.

I was unsure if I should really remove the 3.6 classifier at this time, but removing it doesn't prevent installation on 3.6, removing it achieves consistency with changes in #240, and from #240 (comment) it appears that 3.6 support is not a goal.

It may make sense to add 3.12 later once any changes needed to install and pass all tests locally and on CI have been made, but I did not add it here.

I was unsure if the commit here should be prefixed build:, cleanup:, or something else. I can amend the message and force-push if that would be helpful.

This updates the classifiers listed in setup.py.

Removals:

- Python 2 classifiers. Although a significant amount of the code
  remains written in the common subset of Python 2 and Python 3,
  the codebase overall no longer supports Python 2. For example,
  collections.abc is imported.

- Python 3.5. Not all tests reliably pass. test_regression_208
  sometimes passes and sometimes raises TypeError. Later versions
  do not show such nondeterministic behavior, even when the test is
  run many times in succession (it always passes).

- Python 3.6. Tests still pass. This version does appear still to
  work. However, 3.6 has been unsupported by the PSF for a
  significant time, and it is no longer tested in tox.ini or in the
  CI test workflow.

Additions: 3.8, 3.9, 3.10, and 3.11.

While editing the classifiers, I also removed some unused imports.
@cwacek cwacek merged commit 4cac473 into cwacek:master Aug 17, 2023
7 checks passed
@EliahKagan EliahKagan deleted the classifiers-versions branch August 17, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants