특정 사용자가 작성한 리뷰 목록 조회 API 추가 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
chaewss
reviewed
Nov 15, 2023
| * @param userId 사용자 ID | ||
| * @param sortBy 정렬 정보 | ||
| * @param pageable 페이지 정보 | ||
| * @return 리뷰 목록 |
There was a problem hiding this comment.
Suggested change
| * @return 리뷰 목록 | |
| * @return 리뷰 목록 | |
| * @throws ForbiddenException 정회원이 아닌 회원이 0페이지가 아닌 다른 페이지를 조회하는 경우 | |
| * @throws NotFoundException 해당 회원이 존재하지 않는 경우 |
Comment on lines
205
to
211
| if (loginUser == null || loginUser.getRole() != Role.REGULAR) { | ||
| if (pageable.getPageNumber() > 0) { | ||
| throw FORBIDDEN_REVIEW; | ||
| } else { | ||
| pageable = PageRequest.of(pageable.getPageNumber(), 5); | ||
| } | ||
| } |
There was a problem hiding this comment.
해당 부분은 특정 상품 리뷰 목록 조회 API에서도 사용하는 로직이라 모듈화하는건 어떻게 생각하세요?
There was a problem hiding this comment.
@chaewss 좋은 생각인 것 같아요. 수정했습니다!
chaewss
reviewed
Nov 16, 2023
src/docs/asciidoc/api-doc.adoc
Outdated
| @@ -362,7 +362,25 @@ include::{snippets}/review-controller-test/respond_200_when_success_to_read_prod | |||
| ==== Sample Response | |||
| include::{snippets}/review-controller-test/respond_200_when_success_to_read_product_reviews/http-response.adoc[] | |||
|
|
|||
| === 4-5. 리뷰 좋아요 추가 | |||
| === 4-5. 특정 사용자의 리뷰 목록 조회 | |||
There was a problem hiding this comment.
저는 특정 회원의 값을 조회하는 api들은 1. 회원 부분에 넣었는데 이 부분 상의해보면 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Issue
🔑 Key Changes