Allow overriding SlugService by resolving it from the service container #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @justRau. Can you look into why the tests are failing? |
|
@cviebrock I've triggered Actions on my fork's new branch (https://github.com/justRau/eloquent-sluggable/commits/refs/heads/justRau-patch-2/) from Tests failure on basically the master branch: https://github.com/justRau/eloquent-sluggable/actions/runs/12354157246/job/34474862720 I currently have no idea, why that error happens. |
|
Also, I'm running the code from this PR in a production application using https://github.com/symplify/vendor-patches, all's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiated using
new, the SlugService cannot be overridden by app code.Resolving SlugService from the container, allows for overriding.