-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds DoG-HardNet model #103
Conversation
Hi @ducha-aiki, thank you for this excellent contribution! This model seems to be a straight improvement over SIFT+LightGlue, which is great. I think we can simplify the DogHardNet class a bit. Inherit from SIFT, and put these few lines into the If this is done we can merge, and I can attach your weights to the release. |
@Phil26AT Thanks. I can do that, however, there will be a slight inefficiency in the code, as the SIFT descriptors computation will be wasted. |
@Phil26AT Done. I have also added missing import into |
Looks great!
Yes correct, but this would only apply to opencv SIFT extraction (pycolmap does not allow to turn description off). Did you ever benchmark this? If the difference is big we can maybe pass a flag to |
@Phil26AT that is 10ms, which we probably can ignore - the HardNet extraction is dominating the time anyway (esp. on CPU). |
Okay yeah I guess we can ignore it for now. I'll merge this PR then, thank you for the contribution! |
Great, thank you! Don't forget to name the weights under your convention. |
In the assets, |
Fixed, thank you for the note. |
@Phil26AT Sorry to bother you again, but it is still wrong at release page: |
@ducha-aiki I am sorry for the typo, it is fixed now. |
Link to the weights: http://cmp.felk.cvut.cz/~mishkdmy/models/doghardnet_lightglue.pth
Benchmark on MD1500 with OpenCV: