Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick and dirty Dockerfile #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

svniedner
Copy link

I have added a quick-and-dirty Dockerfile which serves well for trying the software, but is not really suitable for production use. This would require to move all directories with persistence on docker volumes. This would require your support, and I am happy to develop and share the code then. Best, Sven

@Rafiot
Copy link
Collaborator

Rafiot commented Apr 24, 2024

Thank you for the work!

It probably makes sense to use the redis (or more probably valkey) and kvrocks docker images instead of building from scratch in the docker. And regarding the docker volumes, what do you need from me?

@svniedner
Copy link
Author

svniedner commented Apr 24, 2024 via email

@Rafiot
Copy link
Collaborator

Rafiot commented Apr 24, 2024

we were waiting for valkey to be stable before switching to it. It seems to be the case now.

The reason the default install guide tells you to install kvrocks and redis from sources is just because the versions in the distributions are too often very outdated and/or no-existant. This is not the case if you install from docker. We mostly need relatively recent, but not a specific version.

Regarding the feeders directoires, I'm guessing the approach is to go with docker compose -> https://github.com/Lookyloo/lookyloo/blob/main/docker-compose.yml ?

I'm not a docker user, and will not be using it in production settings, so I'll try to make your life as easy as possible, but docker will not be the default approach to use the tool.

@svniedner
Copy link
Author

svniedner commented Apr 24, 2024 via email

@Rafiot
Copy link
Collaborator

Rafiot commented Apr 24, 2024

The main reason I don't use docker by default is that it is an absolute pain when I write code on the project (and it makes debugging a nightmare).

Moving the persistent directories somewhere else is possible, but it will break the existing installations, but it will be in a docker-context much more future-proof. I'll see what I can do there.

And regarding the content tracked in git, it is for some, as submodules, so they should not be fetched by default until you run the importers.

@svniedner
Copy link
Author

svniedner commented Apr 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants