Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_binaries.jl #97

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

amontoison
Copy link
Contributor

Copy the license of each dependency when we generate the precompiled archives.

@cvanaret cvanaret merged commit 9281305 into cvanaret:main Nov 16, 2024
3 checks passed
@amontoison amontoison deleted the ci_generate_binaries branch November 16, 2024 20:01
@amontoison
Copy link
Contributor Author

@cvanaret
Can you temporary comment these lines in generate_binaries.jl ?

      for folder in readdir("products/$platform/deps/licenses")
        cp("products/$platform/deps/licenses/$folder", "products/$platform/share/licenses/$folder")
      end
      rm("products/$platform/deps/licenses", recursive=true)

I don't why but I have an error on my fork and the CI build for a new release will fail because of that.

@cvanaret
Copy link
Owner

cvanaret commented Nov 16, 2024

@cvanaret Can you temporary comment these lines in generate_binaries.jl ?

Addressed here: #99
I retagged v1.3.0 🤞

@cvanaret
Copy link
Owner

I still get the error with rm -rf /opt/${target}/${target}/sys-root/System.

@amontoison
Copy link
Contributor Author

I don't have this issue with a a local build.
So I don't why we have that with GHA.

@@ -47,6 +30,12 @@ for (platform, libdir, ext) in platforms
# Unzip the tarball of the dependencies
run(`tar -xzf products/$platform/deps.tar.gz -C products/$platform`)

# Copy the license of each dependency
for folder in readdir("products/$platform/deps/licenses")
cp("products/$platform/deps/licenses/$folder", "products/$platform/share/licenses/$folder")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need
mkdir "products/$platform/share
mkdir "products/$platform/share/licenses
here?

@cvanaret
Copy link
Owner

The binary generation failed with:

Run julia --color=yes .github/julia/generate_binaries.jl
ERROR: LoadError: IOError: mkdir("products/aarch64-apple-darwin-cxx11/share/licenses/ASL"; mode=0o777): no such file or directory (ENOENT)

see https://github.com/cvanaret/Uno/actions/runs/11879298357/job/33101034439#step:9:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants