Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix the compilation on Windows #92

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

amontoison
Copy link
Contributor

@amontoison amontoison commented Nov 15, 2024

@odow @cvanaret
HiGHS provides some configuration files for CMake, making it easier to detect when compiling it with other libraries like Uno.

The issue is that these configuration files use libuno.dll.a on Windows as an entry point for linking.
A file *.dll.a is an import library (neither static nor shared) — see my explanation here.
If we use -DHIGHS=${libdir}/libhighs.dll, we create another entry point that leads to duplicate symbols during the linking phase.

I modified the files build_tarballs_*.jl so that we use the import library of HiGHS on Windows to ensure a single entry point.

After merging this PR, Charlie, you can retrigger the CI build by forcing the tag with:

git tag v1.3.0 -f
git push --tags -f

@cvanaret cvanaret merged commit 5bcfe7f into cvanaret:main Nov 15, 2024
3 checks passed
@amontoison amontoison deleted the hotfix_release branch November 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants