A few ChordSymbol fixes #1702
Merged
A few ChordSymbol fixes #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edal', should be 'B-pedal').
|
I did modify one test to actually test that the new code did the right thing. But it's on the same line as before, which was already tested, so no coverage change. |
|
Added another fix: CHORD_TYPES['Neapolitan'] had '1,2-,3,5-' but should be '1,-2,3,-5'. |
…o an add. I'm assuming this is what "should we throw an exception???? for now yes, but maybe later we should" is referring to.
gregchapman-dev
changed the title
|
Third fix: when applying ChordSymbol modifications, if a modification is an 'alter' for a degree not in the ChordSymbol, turn it into an 'add' instead (and apply it). |
|
Ah, this was leftover from an early version of ChordSymbol where b was used instead of -. Just fixed a doc that also referenced the old way. Will merge when tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(was 'Bbpedal', should be 'B-pedal')