Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow id and email identifiers to be updated when cio_id specified #109

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

richdawe-cio
Copy link
Contributor

@richdawe-cio richdawe-cio commented Dec 8, 2023

This is an alternative solution to #78 . It's an alternative to the solution implemented in #102 .

This PR updates the identify operation to use the cio_id to identify customers, if it's present. This will allow users of the client library to update customers using the existing identify call by passing in the cio_id, and whatever attributes they want. This may include the id (external ID) or email, but those would not be required.

Changing the id and email for a customer with cio_id of "f000000d" would then look like this:

$customerio.identify(
  :cio_id => "f000000d",
  :id => 1005,
  :email => "[email protected]"
)

@richdawe-cio richdawe-cio marked this pull request as draft December 8, 2023 14:49
@richdawe-cio richdawe-cio marked this pull request as ready for review December 8, 2023 14:57
@richdawe-cio richdawe-cio merged commit 694f178 into main Dec 8, 2023
12 checks passed
@richdawe-cio richdawe-cio deleted the identify_by_cio_id branch December 8, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants