Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parts of previous pull requests, add local unique IDs and fix latest deprecation warnings #288

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

jaym25
Copy link
Collaborator

@jaym25 jaym25 commented Jun 18, 2024

A full cleaning and update of the Remote Home-Assistant component.

@lukas-hetzenecker
Copy link
Member

Except for the version bump, happy to merge that, and could make a new release afterwards

You can let me know then if I should still add you to the repo :)

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

Go ahead and add me. I would be honored.

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

You might have to help me a little with the process, as I'm green when it comes to this stuff...

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

If you use this component, you'll love the unique IDs where you can easily rename and assign the entities to areas plus everything else. Been having that for several months now and love it! I'm also using it bidirectionally.

@lukas-hetzenecker
Copy link
Member

Thanks, I have added you :) - feel free to merge the PR ;)

@jaym25 jaym25 merged commit b8b921c into custom-components:master Jun 18, 2024
2 of 3 checks passed
@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

That felt good! It didn't pass the manifest alphabetical requirement test, but I just did it anyway. Hope that's not a problem :-)

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

@lukas-hetzenecker what are the red and green gauges on each file in a pull request supposed to tell you?

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 18, 2024

@lukas-hetzenecker do we have to anything else to make it show up in HACS?

@lukas-hetzenecker
Copy link
Member

Congratulations on the first merge @jaym25 🥳🥳🥳
The tests are indeed not that important, we can fix that later

For making it show up in HACS - yes, there's some additional step
Under the release tab ( https://github.com/custom-components/remote_homeassistant/releases ) we have to "Draft a new release". For the tag, a new tag with the same version number as in the manifest file can be created.
Then some (potentially autogenerated) release notes, and it will show up in HACS. Do you want to have the honor? :)

@lukas-hetzenecker
Copy link
Member

Oh, and the red/green gauges in the Files just show the amount of the lines of code that have been removed/added

@jaym25
Copy link
Collaborator Author

jaym25 commented Jun 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants