Fix(csrf): Send csrf token for the /change-password path
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaung Zin Hein <[email protected]>
evert
reviewed
Oct 4, 2024
src/middleware/csrf.ts
Outdated
Comment on lines
23
to
25
| if (!safeMethods.includes(ctx.method) && !safePaths.includes(ctx.path)) { | ||
| ctx.validateCsrf(); | ||
| if(ctx.path === '/change-password'){ | ||
| ctx.validateCsrf(await ctx.getCsrf()); |
There was a problem hiding this comment.
This change unfortunately doesn't really make sense. getCsrf() returns the current CSRF token, so this will always be valid.
The point of validateCsrf is to validate a token that was submitted with the request. The solution here would be to ensure that the HTML form has an <input type="hidden" name="csrf-token" value"..." /> included.
There was a problem hiding this comment.
Gotcha. B/c the current form doesn't have the csrf-token value, I'll try this:
- Send csrf-token from the
/change-passwordmw. - Attach csrf-token in
changepassword.hbs. - Validate the token back in the server.
Signed-off-by: Kaung Zin Hein <[email protected]>
|
Thank you so much for this! |
|
no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #534.
A
csrf-tokenalready exists onctx.session. But we need to pass it tovalidateCsrf().