-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update css, slight updates in form markup #353
Conversation
{{{ body }}} | ||
<main> | ||
{{{ body }}} | ||
</main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some markup to be flexible in case some pages might expand in the future; individual pages could receive more markup (brand messaging/visuals / additional copy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
A few notes. I like the general direction! There's some flaws I think (maybe just because its incomplete), but the larger feedback is .. i had hoped that we could unify the 'hal/curveball browser' pages and forms a bit more. This feels to me its kind of becoming its own thing. This is probably my fault for not giving better directions. But that said, the current login/registration screens also dont match the curveball branding so it's still a great step up =) |
{{{ body }}} | ||
<main> | ||
{{{ body }}} | ||
</main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
<link rel="preconnect" href="https://fonts.googleapis.com"> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
<link href="https://fonts.googleapis.com/css2?family=Montserrat:wght@300;600&display=swap" rel="stylesheet"> | ||
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, since this is a security product, I don't think we should reach out to other services.
We could embed our own fonts if we want to, but google fonts tracks users and I think this sends the wrong message.
Closing because of no activity |
Here's a first shot at #350, any feedback is welcome!