Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handing of raw strings in rust #2681

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Proper handing of raw strings in rust #2681

merged 2 commits into from
Nov 16, 2024

Conversation

AndreasArvidsson
Copy link
Member

Fixes #2678

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner November 16, 2024 13:52
auscompgeek
auscompgeek requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also have a test for more hashes, like r##"hello"##?

@AndreasArvidsson
Copy link
Member Author

Could we also have a test for more hashes, like r##"hello"##?

Oh that is valid? I did not add support for that.

@auscompgeek
Copy link
Member

Oh that is valid?

Per the language reference (also linked in the issue), yes :)

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Nov 16, 2024 •
edited
Loading

Oh that is valid?

Per the language reference (also linked in the issue), yes :)

Tree sitter gives us no help here so all those different combinations with hashes is something we need to solve with regex in that case.

@AndreasArvidsson
Copy link
Member Author

Now we support multiple hashes :)

@pokey pokey added this pull request to the merge queue Nov 16, 2024
Merged via the queue into main with commit d6cc6f9 Nov 16, 2024
15 checks passed
@pokey pokey deleted the rustStrings branch November 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

@auscompgeek auscompgeek auscompgeek approved these changes

Assignees
No one assigned
Labels
lang-rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust raw string breaks scopes
3 participants
@AndreasArvidsson @auscompgeek @pokey