Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty commit to trigger deploy #2636

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Empty commit to trigger deploy #2636

merged 1 commit into from
Aug 5, 2024

Conversation

AndreasArvidsson
Copy link
Member

Checklist

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 5ebe165 Aug 5, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the deploy branch August 5, 2024 07:42
@pokey
Copy link
Member

pokey commented Aug 5, 2024

fwiw you should be able to do this by finding the failed run in our action run history, clicking on it, and hitting re-run in the top right

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Aug 5, 2024

fwiw you should be able to do this by finding the failed run in our action run history, clicking on it, and hitting re-run in the top right

It didn't fail; it was marked as skipped for some reason. I tried to rerun it multiple times, but it was just skipped every time. Quite strange.

@pokey
Copy link
Member

pokey commented Aug 5, 2024

i mean the test run, not the deploy. see how the test run is failed in that link I sent. The deploy will skip if the test fails. If you re-run the test and it succeeds, then the deploy should go ahead

@AndreasArvidsson
Copy link
Member Author

Ah of course. Thank you!

@auscompgeek
Copy link
Member

We should work out why the tests are flaky 😅

@pokey
Copy link
Member

pokey commented Aug 5, 2024

We should work out why the tests are flaky 😅

it's actually a fairly easy fix now that we have better abstractions over fs #2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants