Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installation instructions suggest installing a speech engine #2061

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

C-Loftus
Copy link
Contributor

Multiple users have had errors with this. This adds verbosity so we don't need to merge necessarily if you want a very terse installation process but I think it might be helpful. Talon installation UX remains rather weak so I think its good to specify

@C-Loftus C-Loftus closed this Mar 14, 2024
@C-Loftus C-Loftus deleted the update-installation branch March 14, 2024 17:32
@pokey
Copy link
Member

pokey commented Mar 14, 2024

Sorry to be...incredibly slow on this one 😅. Did you close this one because you gave up on it ever getting merged or because some change to Talon rendered it no longer necessary?

@C-Loftus C-Loftus restored the update-installation branch March 14, 2024 17:39
@C-Loftus
Copy link
Contributor Author

No worries I closed it since I thought you weren't interested. Feel free to open it back up if desired. I've seen a fair bit of people within the slack miss the fact they have to install a speech engine if they are installing Talon specifically for cursorless ( so I thought it might be useful to specify) (i.e. people that see cursorless from a talk, and want to try it out may miss the speech engine part of installing talon since they are more concerned with cursorless setup)

But this isn't a big deal either way and may not be necessary.

@pokey
Copy link
Member

pokey commented Mar 14, 2024

Yeah I think let's reopen; I do think it's potentially helpful so I'd prefer not to lose track of it. It just got lost in the backlog

@pokey pokey reopened this Mar 14, 2024
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording suggestions (it's a menu not a tab, right?). Otherwise, any reason not to merge this?

@@ -1,6 +1,7 @@
# Installation

1. Install [Talon](https://talonvoice.com/)
- Make sure a speech engine is installed by clicking on the `Speech Recognition` tab after clicking the Talon tray icon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Make sure a speech engine is installed by clicking on the `Speech Recognition` tab after clicking the Talon tray icon
- Make sure a speech engine is installed (click the Talon tray icon, then select one from the `Speech Recognition` menu)

@phillco phillco changed the title Update installation Make installation instructions suggest installing a speech engine Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants