Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS tests sometimes temporarily fail on CI #2538

Open
saidelike opened this issue Jul 19, 2024 · 2 comments · May be fixed by #2638
Open

macOS tests sometimes temporarily fail on CI #2538

saidelike opened this issue Jul 19, 2024 · 2 comments · May be fixed by #2638
Labels
app-vscode Issues related to VSCode support

Comments

@saidelike
Copy link
Collaborator

macos tests fails randomly sometimes on CI.

image

Pokey tried bumping the sleep but hasn’t been able to get it to pass reliably. The workaround in the meantime is to re-run the job.

An example is the failed job in attempt 1 which when we re-run the job works for attempt 2.
@saidelike saidelike added the app-vscode Issues related to VSCode support label Jul 19, 2024
@pokey
Copy link
Member

pokey commented Jul 27, 2024

We should probably use a fake talonSpokenForms component here

cursorless/packages/cursorless-vscode/src/extension.ts

Line 98 in a09177b

const talonSpokenForms = new FileSystemTalonSpokenForms(fileSystem);

@AndreasArvidsson
Copy link
Member

Agreed

@pokey pokey mentioned this issue Aug 5, 2024
Merged
3 tasks
@AndreasArvidsson AndreasArvidsson linked a pull request Aug 5, 2024 that will close this issue
Don't use file system for custom spoken form tests #2638
Draft
@phillco phillco changed the title OSX tests sometimes temporarily fail on CI macOS tests sometimes temporarily fail on CI Aug 6, 2024
@phillco phillco linked a pull request Aug 6, 2024 that will close this issue
Draft
@AndreasArvidsson AndreasArvidsson mentioned this issue Aug 6, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 6, 2024
@AndreasArvidsson
Try to fix CI flakiness by adding sleep in custom regex scope test (#…
ab208a3 
…2645)

Possible solution to
#2538

As of this writing this seems to be required for mac CI, but not other
platforms

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-vscode Issues related to VSCode support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use file system for custom spoken form tests cursorless-dev/cursorless
3 participants
@saidelike @pokey @AndreasArvidsson