Handle InProgressEtd::NO_EMBARGO values in the actor stack
#1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1492 is related, but better taken on when |
added 2 commits
August 6, 2018 17:40
This string was hard coded in a number of places, which was fragile. Some handling of this is going to be required elsewhere (pending a more compelete refactor here), so the constant seems necessary.
The `PregradEmbargo` actor is responsible for setting up attributes for a six-year pregraduation embargo when an `embargo_length` is passed during `Etd` creation. This works more or less the same as its predecessor, but relies more on base Hyrax behavior. The values passed here are eventually interpreted at graduation time to determine the post-grad embargo release date. However, the `InProgressEtd` data stores a specific string indicating that no embargo is requested, and passes that value to the stack. This is always interpreted as a request for a pregrad embargo. Ideally, we would handle this at the edge of `InProgressEtd` so other parts of the application don't need to be aware of this blessed string. It's likely that `InProgressEtd` needs this to be round-tripabble, and the handling for transformation of this data lives across various methods. Rather than attempt an immediate refactor, we fix the bug by handling the special data in the actor stack. We raise a warning so the larger fix won't get ignored. Fixes #1485.
no-reply
force-pushed
the
new-form-no-embargo
branch
from
1eea962 to
a558747
Compare
val99erie
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PregradEmbargoactor is responsible for setting up attributes for asix-year pregraduation embargo when an
embargo_lengthis passed duringEtdcreation. This works more or less the same as its predecessor, but relies more
on base Hyrax behavior. The values passed here are eventually interpreted at
graduation time to determine the post-grad embargo release date.
However, the
InProgressEtddata stores a specific string indicating that noembargo is requested and passes that value to the stack. This is always
interpreted as a request for a pregrad embargo.
Ideally, we would handle this at the edge of
InProgressEtdso other parts ofthe application don't need to be aware of this blessed string. It's likely that
InProgressEtdneeds this to be round-tripabble, and the handling fortransformation of this data lives across various methods. Rather than attempt an
immediate refactor, we fix the bug by handling the special data in the actor
stack. We raise a warning so the larger fix won't get ignored.
Fixes #1485.