fix(FilterBar): hide clear all button when there's nothing to clear #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 03bc812 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
changed the title
|
(putting in review for chromatic) |
dougmacknz
force-pushed
the
KZN-2858/disable-clearAll-btn-filter-bar
branch
from
5c5e6b7
to
6b68fa1
Compare
dougmacknz
changed the title
dougmacknz
force-pushed
the
KZN-2858/disable-clearAll-btn-filter-bar
branch
from
3d0fcff
to
e817bc8
Compare
|
Seems to be a little buggy Screen.Recording.2024-11-26.at.4.50.21.PM.mov |
dougmacknz
force-pushed
the
KZN-2858/disable-clearAll-btn-filter-bar
branch
from
dd1f4e3
to
5075111
Compare
packages/components/src/Filter/FilterBar/_docs/FilterBar.spec.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterBar/_docs/FilterBar.spec.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterBar/_docs/FilterBar.spec.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterBar/_docs/FilterBar.spec.stories.tsx
Show resolved
Hide resolved
...ilterDateRangePicker/subcomponents/FilterDateRangePickerField/FilterDateRangePickerField.tsx
Show resolved
Hide resolved
dougmacknz
force-pushed
the
KZN-2858/disable-clearAll-btn-filter-bar
branch
from
99e3d5f
to
1d5b82c
Compare
dougmacknz
force-pushed
the
KZN-2858/disable-clearAll-btn-filter-bar
branch
from
1d5b82c
to
03bc812
Compare
dougmacknz
approved these changes
Nov 28, 2024
Zystix
pushed a commit
that referenced
this pull request
Dec 2, 2024
…5322) * fix(FilterBar): disable clearall if no active filters * add changeset * add isClearable into the context * update and add new test for disable functionality * Hide button instead of disabling * Make isClearable check more efficient * Add test for hasRemovableFilter * Adjust changeset message * Fix test * Add SB tests for clear all and remove vitest equivalents * Add extra step to test * delete from object instead of setting to undefined * Don't update value in FDRP on load if empty * Add workaround for DateRangePicker in isClearable * Adjust story names * Split test stories up * Use toBeNull() instead of toBe(null) * Check value is not undefined * Switch toBeNull to not.toBeInTheDocument --------- Co-authored-by: Doug MacKenzie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://cultureamp.atlassian.net/browse/KZN-2858
What