Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableMongo configuration for Vent-only mode #363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edemaine
Copy link

@edemaine edemaine commented Sep 23, 2020

Adds a disableMongo configuration option for disabling all the Mongo overrides, but still connecting to the Redis server, which I gather from #359 and #361 is useful for just using Vent.

I thought about naming this overrideMongo to parallel the old overridePublishFunction (and can change if desired), but given #357, I feel like it could be helpful to override Mongo even when Redis isn't being used, so felt like this was a more accurate name.

Fix #359, fix #361, and sort of relevant to #323.

@afrokick
Copy link

afrokick commented Sep 23, 2020

@edemaine thanks. I had a test and it works perfectly!

@jamesgibson14
Copy link
Contributor

@edemaine This is perfect timing, I was wanting to use Vent but wasn't quite ready to switch to full mongo redis-oplog. I have already done a quick test and it works great. Thanks.

@theodorDiaconu
Copy link
Contributor

I would rather use the verbose version ( "extendMongoCollection: bool") + you also have to add to the documentation about a "Vent Only Solution". the problem with this is that we have overridePublishFunction and disableMongo. Something doesn't fill uniform about this. "DisableMongo" makes me think of something bad like disabling the database all together.

@afrokick
Copy link

@edemaine could you please finish it?

@edemaine
Copy link
Author

@theodorDiaconu OK, I did the suggested rename -- that is a better name. I also added a small section to docs/vent.md. Let me know if you'd like this moved somewhere else.

Keep in mind that overridePublishFunction doesn't exist anymore, as redis-oplog no longer overrides Meteor.publish in any situation (as far as I can tell).

@ramezrafla
Copy link
Contributor

Right, observeChanges is what is overridden now. It sends directly to the regular callbacks in Meteor's publish.
My feeling is what we should have a separate package for redis-only events. This package is becoming bloated.

@afrokick
Copy link

@ramezrafla I want to use only Vent because another features require a lot of time to refactor project. So, I’ll adopt project step by step.

@afrokick
Copy link

@theodorDiaconu seems like @edemaine finished the work. Could you please review and merge it?

@theodorDiaconu
Copy link
Contributor

We'll have to fix the tests. To be able to merge.

@edemaine edemaine mentioned this pull request Sep 22, 2022
@jamesgibson14
Copy link
Contributor

I have been using this option for a couple of years now on some prod apps, its great for real-time redis data through ddp and Vent. It would be nice to get it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish/subscribe doesn't work when redis-oplog disabled How to use Vent only
5 participants