Hyacinth 2.6.x error messages

app/jobs/process_digital_object_import_job.rb

@@ -49,7 +49,8 @@ def self.find_or_create_digital_object(digital_object_data, user, digital_object
       # We're updating data for an existing object
       existing_object_for_update(digital_object_data, user)
     else
-      new_object(digital_object_data['digital_object_type']['string_key'], user, digital_object_import)
+      digital_object_type = digital_object_data['digital_object_type']['string_key'] if digital_object_data['digital_object_type']
+      new_object(digital_object_type, user, digital_object_import)
     end
   end
 
@@ -109,7 +110,7 @@ def self.existing_object_for_update(digital_object_data, user)
   end
 
   def self.new_object(digital_object_type, user, digital_object_import)
-    digital_object = DigitalObjectType.get_model_for_string_key(digital_object_type).new
+    digital_object = DigitalObjectType.get_model_for_string_key(digital_object_type || :missing).new
     digital_object.created_by = user
     digital_object.updated_by = user
     digital_object

spec/jobs/process_digital_object_import_job_spec.rb

@@ -84,6 +84,18 @@
       expect(klass).to receive(:new_object)
       klass.find_or_create_digital_object(digital_object_data, user, digital_object_import)
     end
+    context "no digital_object_type given for a new object" do
+      let(:digital_object) { klass.find_or_create_digital_object(digital_object_data, user, digital_object_import) }
+      let(:expected_message) { "Invalid DigitalObjectType string key: missing" }
+      before do
+        digital_object_data.delete('digital_object_type')
+      end
+
+      it "fails with a legible error" do
+        expect(digital_object).to be_nil
+        expect(digital_object_import.digital_object_errors).to include(expected_message)
+      end
+    end
   end
 
   describe ".handle_unexpected_processing_error" do

spec/models/concerns/digital_object/publishing_spec.rb

@@ -74,5 +74,18 @@
     end
   end
 
-  describe '#execute_publish_action_for_target'
+  describe '#execute_publish_action_for_target' do
+    let(:pubtarget_pid) { 'pubtarget:c' }
+    let(:pubtarget) { instance_double(DigitalObject::PublishTarget, pid: pubtarget_pid) }
+    let(:success) { digital_object.execute_publish_action_for_target(:publish, pubtarget, true) }
+    context 'raises RestClient::ExceptionWithResponse with no response attribute' do
+      before do
+        allow(pubtarget).to receive(:publish_target_field).with('publish_url').and_return("http://localhost/publish")
+        allow(pubtarget).to receive(:publish_digital_object).and_raise(RestClient::ExceptionWithResponse)
+      end
+      it 'returns false' do
+        expect(success).to be false
+      end
+    end
+  end
 end