Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly editor #124

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Blockly editor #124

wants to merge 17 commits into from

Conversation

aslakhellesoy
Copy link
Contributor

@aslakhellesoy aslakhellesoy commented Nov 18, 2022

🤔 What's changed?

Add a Blockly editor for Gherkin. Preview:

Screenshot 2022-11-28 at 11 23 51

⚡️ What's your motivation?

My motivation is to lower the barrier of entry for people who are either new to Cucumber, or for people with little programming experience. In some cases, a visual editor might also be preferable for seasoned developers who are familiar with Cucumber.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

The following needs to be done before this can be merged to main and be included in the next release:

  • Make the blockly editor be an alternative view, similar to how a .md document can be viewed in either text mode or rendered mode.
    • Associate the blockly editor with the .feature extension rather than the .gherkin extension, which is just a temporary workaround.
  • Make sure edits in the blockly editor saves the .feature file back to the file system.
  • Take up the full height and add a scroll bar - if there are many step definitions, they disappear at the bottom of the screen
  • Add a disclaimer about unsupported features

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy changed the title Blockly2 Blockly editor Nov 28, 2022
@mrkaiser
Copy link

mrkaiser commented Dec 7, 2022

hi @aslakhellesoy

I have followed the build instructions as with all other times I've worked on the extension. However the UI layer will not load if I copy a working .feature to a .gherkin. It claims there is an AssertionError in a modal and this to the output console:

[Error - 7:33:33 PM] Error: Webview is disposed
	at u.assertNotDisposed (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:94:201081)
	at get webview [as webview] (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:94:199876)
	at sg.updateWebviewHtml (/home/mrkaiser/Documents/code/cucumber/vscode/out/extension.js:499:21143)
	at sg.onReindexed (/home/mrkaiser/Documents/code/cucumber/vscode/out/extension.js:499:21417)
	at Gd.onReindexed (/home/mrkaiser/Documents/code/cucumber/vscode/out/extension.js:541:931)
	at Gd.<anonymous> (/home/mrkaiser/Documents/code/cucumber/vscode/out/extension.js:499:19780)
	at Generator.next (<anonymous>)
	at o (/home/mrkaiser/Documents/code/cucumber/vscode/out/extension.js:499:11352)
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
[Error - 7:33:33 PM] Please report an issue at https://github.com/cucumber/language-service/issues with the above stack trace

Please advise. I believe I can finish the remaining work on this extension.

@aslakhellesoy
Copy link
Contributor Author

Hi @mrkaiser I'm not able to reproduce what you describe. This is what I did:

Dec-08-2022 13-29-50

@mrkaiser
Copy link

mrkaiser commented Dec 9, 2022

Okay I will try again tonight. It might've been a PEBKAC. Thank you for the response.

@aslakhellesoy
Copy link
Contributor Author

Hi @mrkaiser did you have any luck with this?

@kieran-ryan kieran-ryan added the ⚡ enhancement Request for new functionality label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants