Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pickle name if parameterized #34

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jun 21, 2024

🤔 What's changed?

Include the pickle name in the test name, if the pickle was parameterized.

Fixes: #27, properly this time.

📋 Checklist:

@mpkorstanje mpkorstanje force-pushed the include-pickle-name-if-parameterized branch 3 times, most recently from 97d2f82 to c83d85a Compare June 21, 2024 13:42
mpkorstanje added a commit to cucumber/compatibility-kit that referenced this pull request Jun 21, 2024
When using a Scenario Outline it is possible to use a placeholder in the
name of that Scenario Outline. The resulting pickle will have the
placeholder replaced with a value from the example tables.

This allows us to test use cases where this matter such as:
- cucumber/junit-xml-formatter#34
- cucumber/testng-xml-formatter#4

Fixes: #96
mpkorstanje added a commit to cucumber/compatibility-kit that referenced this pull request Jun 22, 2024
When using a Scenario Outline it is possible to use a placeholder in the
name of that Scenario Outline. The resulting pickle will have the
placeholder replaced with a value from the example tables.

This allows us to test use cases where this matter such as:
- cucumber/junit-xml-formatter#34
- cucumber/testng-xml-formatter#4

Fixes: #96
mpkorstanje added a commit to cucumber/compatibility-kit that referenced this pull request Jun 22, 2024
When using a Scenario Outline it is possible to use a placeholder in the
name of that Scenario Outline. The resulting pickle will have the
placeholder replaced with a value from the example tables.

This allows us to test use cases where this matter such as:
- cucumber/junit-xml-formatter#34
- cucumber/testng-xml-formatter#4

Fixes: #96
@mpkorstanje mpkorstanje force-pushed the include-pickle-name-if-parameterized branch 2 times, most recently from 1d12a3d to 8da09bc Compare June 22, 2024 12:52
Include the pickle name in the test name, if the pickle was parameterized.

Fixes: #27, properly this time.
@mpkorstanje mpkorstanje force-pushed the include-pickle-name-if-parameterized branch from 8da09bc to a95b611 Compare June 22, 2024 13:25
@mpkorstanje mpkorstanje marked this pull request as ready for review June 22, 2024 13:51
@mpkorstanje mpkorstanje merged commit 3a1e730 into main Jun 22, 2024
3 checks passed
@mpkorstanje mpkorstanje deleted the include-pickle-name-if-parameterized branch June 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong test name in XML report when running Scenario Outline
1 participant