Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/cucumber/messages/go/v21 to v22 #120

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 14, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/cucumber/messages/go/v21 require major v21.0.1 -> v22.0.0

Release Notes

cucumber/messages (github.com/cucumber/messages/go/v21)

v22.0.0

Compare Source

Added
  • Added source reference to parameter type (#​45)
Fixed
  • Corrected Java and PHP generators to allow running using Docker on Windows (#​146)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@dolmen
Copy link
Contributor

dolmen commented Jul 13, 2023

This bot is buggy:

  • it upgrades major versions. That should be a task left to maintainers.
  • as it upgrades major version, it should fully do the job. However it doesn't update imports in *.go, so the upgrade doesn't happen.

Also, the repo has generated code, so that would not work anyway.

So I have made #133 which is the right thing.

@mpkorstanje
Copy link
Contributor

it upgrades major versions. That should be a task left to maintainers.

That's a very narrow view of what this bot does. It also:

  • It signals that there are upgrades available
  • It attempts to do the work of upgrading manually. But as you noticed, badly, unfortunately.

Also, the repo has generated code, so that would not work anyway.

That might possibly solved with a custom manager. We're using one for Ruby's GemSpecs for example.

@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch 9 times, most recently from 70341f0 to ee36e33 Compare July 22, 2023 16:50
@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch 2 times, most recently from 6f6dcf1 to 38be090 Compare July 25, 2023 22:00
Copy link
Contributor

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes in imports and go.sum.

@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch from 38be090 to f3f7dd1 Compare July 27, 2023 22:34
@dolmen
Copy link
Contributor

dolmen commented Jul 31, 2023

@CodiumAI-Agent please review

@CodiumAI-Agent
Copy link

How to use PR-Agent

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', just add -config_path=. For example: '/review --pr_reviewer.extra_instructions="focus on the file: ..."'

@dolmen
Copy link
Contributor

dolmen commented Jul 31, 2023

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Analysis

  • 🎯 Main theme: Dependency update
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • Focused PR: Yes, the PR is focused as it only updates a single dependency version in the project.
  • 🔒 Security concerns: No, this PR does not introduce any security concerns as it only updates a dependency version.

PR Feedback

  • 💡 General PR suggestions: The PR is generally well-structured and follows the best practices for dependency updates. However, it would be beneficial to include a brief explanation of why this update is necessary and what improvements or fixes it brings to the project. Additionally, if there are any breaking changes in the updated dependency, it would be helpful to discuss how they are handled or how they affect the project.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', just add -config_path=. For example: '/review --pr_reviewer.extra_instructions="focus on the file: ..."'

@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch 3 times, most recently from 3d6c3d9 to 06a5394 Compare August 5, 2023 16:23
@renovate
Copy link
Contributor Author

renovate bot commented Aug 8, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go/go.sum
Command failed: docker run --rm --name=renovate_a_sidecar --label=renovate_a_child --memory=3584m -v "/tmp/worker/69862c/a1edaf/repos/github/cucumber/gherkin":"/tmp/worker/69862c/a1edaf/repos/github/cucumber/gherkin" -v "/tmp/worker/69862c/a1edaf/cache":"/tmp/worker/69862c/a1edaf/cache" -e GOPATH -e GOPROXY -e GOSUMDB -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e CONTAINERBASE_CACHE_DIR -w "/tmp/worker/69862c/a1edaf/repos/github/cucumber/gherkin/go" ghcr.io/containerbase/sidecar:9.8.2 bash -l -c "install-tool golang 1.21.0 && go get -d -t ./..."
/usr/local/bin/docker: line 4: .: filename argument required
.: usage: . filename [arguments]
tar: This does not look like a tar archive

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now

@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch 3 times, most recently from c495bd4 to 636cc8e Compare August 9, 2023 01:34
@renovate renovate bot force-pushed the renovate/github.com-cucumber-messages-go-v21-22.x branch from 636cc8e to a07283e Compare August 10, 2023 18:07
@mpkorstanje mpkorstanje deleted the renovate/github.com-cucumber-messages-go-v21-22.x branch August 10, 2023 18:10
@renovate
Copy link
Contributor Author

renovate bot commented Aug 10, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 22.x releases. But if you manually upgrade to 22.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants