Skip to content

Commit

Permalink
Added .NET 9 to test matrix (#299)
Browse files Browse the repository at this point in the history
* Added .NET 9 to test matrix
* Update System.Text.Json to version 8
  • Loading branch information
Romfos authored Nov 5, 2024
1 parent d2107f0 commit 8d0c1f2
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-nuget.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x
- uses: cucumber/[email protected]
with:
nuget-api-key: ${{ secrets.NUGET_API_KEY }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
with:
dotnet-version: |
8.0.x
9.0.x
- run: dotnet test
working-directory: dotnet

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- [PHP, Java, Ruby, JavaScript] update dependency messages up to v26
- [Python] Added type annotations ([#283](https://github.com/cucumber/gherkin/pull/283))
- [Python] Switch to pyproject.toml ([#290](https://github.com/cucumber/gherkin/pull/290))
- [.NET] Added .NET 9 to test matrix

### Changed
- [.NET] Drop unsupported frameworks. Now supported target frameworks are .NET 8, .NET Standard 2.0 ([#265](https://github.com/cucumber/gherkin/pull/265))
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<LangVersion>12</LangVersion>
<LangVersion>13</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin.Specs/DependencyValidationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void SystemTextJsonUpgradeBlocker()

var version = typeof(JsonSerializer).Assembly.GetCustomAttribute<AssemblyFileVersionAttribute>().Version;

Assert.Equal("6.0.3524.45918", version); // System.Text.Json Version 6.0.10
Assert.Equal("8.0.1024.46610", version); // System.Text.Json Version 8.0.5
}
}
#endif
2 changes: 1 addition & 1 deletion dotnet/Gherkin.Specs/Gherkin.Specs.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0;net462</TargetFrameworks>
<TargetFrameworks>net9.0;net8.0;net462</TargetFrameworks>
<OutputType>Exe</OutputType>
<StartupObject>Gherkin.Specs.CLI.Program</StartupObject>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin/Gherkin.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Text.Json" Version="6.0.10"/>
<PackageReference Include="System.Text.Json" Version="8.0.5" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 8d0c1f2

Please sign in to comment.