fix: use explicit status field to determine (not) running status #2386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Update the logic in
SupportCodeLibraryBuilder
so instead of using a heuristic (absence ofcwd
) to detect if we are trying to register support code against a non-running install, we have a specific status field that we update along the create/reset/finalize lifecycle.⚡️ What's your motivation?
In #2353 we are seeing several Windows users reporting this error since 10.0.0 with a configuration that works fine in 9.x.x. This suggests the invalid install error might be a false positive and masking a different issue.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.