Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Issue #309 - Makes I18n.get raises correctly when receiving invalid iso_code #310

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abinoam
Copy link
Contributor

@abinoam abinoam commented Jun 15, 2014

See #309

@abinoam
Copy link
Contributor Author

abinoam commented Jun 15, 2014

Failed at JRuby.
I'll take a look at it.

@abinoam
Copy link
Contributor Author

abinoam commented Jun 15, 2014

Took a look and it seems it fails on Java code.
I have no good expertise in Java, sorry.

@os97673
Copy link
Contributor

os97673 commented Jun 16, 2014

JRuby version is failing on Travis :(
You need to provide java implementation too.

@abinoam
Copy link
Contributor Author

abinoam commented Jun 16, 2014

Updating PR soon.

@abinoam
Copy link
Contributor Author

abinoam commented Jun 16, 2014

Now it is passing on Travis.
Could you reevaluate the Pull Request?

@os97673
Copy link
Contributor

os97673 commented Jun 17, 2014

looks fine for me. @aslakhellesoy are we going to release next gherkin from master? If so when?
I do not like idea to merge fix whig will never be fixed :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants