fix: a scope should not get instances from parent scopes

cubos · Jan 21, 2021 · 3ad871f · 3ad871f
1 parent 85fa7d7
commit 3ad871f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/spec/inject.test.ts b/spec/inject.test.ts
@@ -101,16 +101,16 @@ describe("env", () => {
       setupScope(() => {
         const instance3 = use(TestService);
 
-        expect(instance1).toBe(instance3);
+        expect(instance3).not.toBe(instance1);
       });
     });
 
-    setupScope(() => {
-      expect(constructorCalledTimes).toBe(1);
+    expect(constructorCalledTimes).toBe(2);
 
+    setupScope(() => {
       use(TestService);
 
-      expect(constructorCalledTimes).toBe(2);
+      expect(constructorCalledTimes).toBe(3);
     });
   });
 

diff --git a/src/scope-context.ts b/src/scope-context.ts
@@ -8,11 +8,11 @@ export class ScopeContext {
   private readonly values = new Map<string, unknown>();
 
   getServiceInstance(name: string): unknown {
-    return this.serviceInstances.has(name) ? this.serviceInstances.get(name) : this.parent?.getServiceInstance(name);
+    return this.serviceInstances.get(name);
   }
 
   hasServiceInstance(name: string): boolean {
-    return this.serviceInstances.has(name) || (this.parent?.hasServiceInstance(name) ?? false);
+    return this.serviceInstances.has(name);
   }
 
   setServiceInstance(name: string, value: unknown) {