Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPAdapterFromParamsBatch node #526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ErwannMillon
Copy link

This PR creates a new node, IPAdapterFromParamsBatch, which inherits from IPAdapterBatch.

It was previously impossible to use weight schedules with the IPAdapterFromParams node as unfold_batch was not enabled.

@cubiq
Copy link
Owner

cubiq commented May 1, 2024

for the batch option you need to add

    def __init__(self):
        self.unfold_batch = True

but for the attention masking I need to do some testing with animations

@ErwannMillon
Copy link
Author

lol oops typo, tested with the unfold_batch = True but ctrl-z'ed before commit.

was working for weight scheduling + regional conditioning, did not test attn masking

@ErwannMillon
Copy link
Author

hm, doesn't seem to work with regional conditioning when trying to use weight scheduling on one ipa while the other has constant weight. Will check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants