Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insightface extra paths #515

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Guillaume-Fgt
Copy link

In response to issue #367

I modified the insightface_loader function to have this behavior:

  • check if an entry exists for an "insightface" folder inside extra_model_paths.yaml file
  • if no entry (no key "insightface"), previous behavior (use insightface folder in Comfy/models)
  • if multiple entries exist, select the first one as path with a logging.info message to warn the user
  • if only one entry, use this one

Some remarks:

  • the model is automatically downloaded by insightface package. So if you have already used Comfy/models/insightface
    before adding an entry in the yaml file, it will download it in the new place (under yaml_path/models/buffalo_l)
    So, you will have a duplication of the model and have to delete the old one manually.
  • the code still have "buffalo_l" hard coded in FaceAnalysis class. So I think it doesn't adress
    @zulfadzlie remark about "antelopev2" and "buffalo_l" usage. If we want to be able to use an other insightface model
    , it should be made in an other PR I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant