Skip to content

Commit

Permalink
Remove some xfails (#24)
Browse files Browse the repository at this point in the history
* Remove xfail for test_chunk due to Cubed #546 fix

* Remove xfail for test_unary_op (round) due to Xarray #9326 fix
  • Loading branch information
tomwhite authored Sep 23, 2024
1 parent 036e76b commit 666bcfa
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions cubed_xarray/tests/test_xarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ def test_copy(self):
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy())
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy(deep=True))

@pytest.mark.xfail(
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
)
def test_chunk(self):
for chunks, expected in [
({}, ((2, 2), (2, 2, 2))),
Expand Down Expand Up @@ -151,7 +148,7 @@ def test_unary_op(self):
v = self.lazy_var
self.assertLazyAndIdentical(-u, -v)
self.assertLazyAndIdentical(abs(u), abs(v))
# self.assertLazyAndIdentical(u.round(), v.round()) # TODO: fails, see https://github.com/pydata/xarray/pull/9326
self.assertLazyAndIdentical(u.round(), v.round())

def test_binary_op(self):
u = self.eager_var
Expand Down Expand Up @@ -292,9 +289,6 @@ def setUp(self):
self.data, coords={"x": range(4)}, dims=("x", "y"), name="foo"
)

@pytest.mark.xfail(
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
)
def test_chunk(self) -> None:
for chunks, expected in [
({}, ((2, 2), (2, 2, 2))),
Expand Down

0 comments on commit 666bcfa

Please sign in to comment.