Add EXPERIMENTAL comments about XXOptions::io_activity (facebook#11926)

Summary: Context/Summary: this option is experimental right now Pull Request resolved: facebook#11926 Test Plan: no code change Reviewed By: jaykorean Differential Revision: D49985000 Pulled By: hx235 fbshipit-source-id: a5b439ed35e3d6bb04c125f222ac29cd3842d1a1
cube-js · Oct 6, 2023 · 21a1236 · 21a1236
1 parent 2dc63c8
commit 21a1236
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/include/rocksdb/file_system.h b/include/rocksdb/file_system.h
@@ -120,6 +120,7 @@ struct IOOptions {
  // directories and list only files in GetChildren API.
  bool do_not_recurse;
 
+ // EXPERIMENTAL
  Env::IOActivity io_activity = Env::IOActivity::kUnknown;
 
  IOOptions() : IOOptions(false) {}

diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h
@@ -1752,9 +1752,13 @@ struct ReadOptions {
 
  // *** END options only relevant to iterators or scans ***
 
- // ** For RocksDB internal use only **
+ // *** BEGIN options for RocksDB internal use only ***
+
+ // EXPERIMENTAL
  Env::IOActivity io_activity = Env::IOActivity::kUnknown;
 
+ // *** END options for RocksDB internal use only ***
+
  ReadOptions() {}
  ReadOptions(bool _verify_checksums, bool _fill_cache);
  explicit ReadOptions(Env::IOActivity _io_activity);