Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive CI after misconfigured GHA job #42

Merged
merged 12 commits into from
Sep 11, 2024

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Sep 5, 2024

Is was broken in commit 6505f1b. GHA does not allow empty vector in build matrix, and does not start whole workflow, not just a single broken job

It would just say The workflow is not valid. .github/workflows/rust.yml (Line: 129, Col: 15): Matrix vector 'rust' does not contain any values
Like here: https://github.com/cube-js/arrow-rs/actions/runs/10713316185

Is was broken in commit 6505f1b. GHA does not allow empty vector in build matrix, and does not start whole workflow, not just a single broken job
@mcheshkov mcheshkov force-pushed the revive-ci-after-misconfigured-gha-job branch 2 times, most recently from 5a34d7e to 3ffa95f Compare September 5, 2024 18:22
@mcheshkov mcheshkov marked this pull request as ready for review September 5, 2024 18:31
@mcheshkov mcheshkov force-pushed the revive-ci-after-misconfigured-gha-job branch from 3ffa95f to 62e7ec3 Compare September 6, 2024 11:08
mcheshkov and others added 10 commits September 6, 2024 14:25
Can drop this after rebase on commit f0451bb, first released in 7.0.0
It was broken properly, with a bug in test, after commit c296882

Can drop this after rebase on commit e8cc39e "Fix like regex escaping (apache#1085)", first released in 7.0.0
Can drop this after rebase on commit fc04931 "Make rand an optional dependency (apache#674)", first released in 6.0.0
@mcheshkov mcheshkov force-pushed the revive-ci-after-misconfigured-gha-job branch from 62e7ec3 to 15aaad5 Compare September 6, 2024 11:31
@mcheshkov mcheshkov merged commit 419678c into cube Sep 11, 2024
25 checks passed
@mcheshkov mcheshkov deleted the revive-ci-after-misconfigured-gha-job branch September 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants