forked from apache/arrow-rs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive CI after misconfigured GHA job #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is was broken in commit 6505f1b. GHA does not allow empty vector in build matrix, and does not start whole workflow, not just a single broken job
mcheshkov
force-pushed
the
revive-ci-after-misconfigured-gha-job
branch
2 times, most recently
from
September 5, 2024 18:22
5a34d7e
to
3ffa95f
Compare
mcheshkov
force-pushed
the
revive-ci-after-misconfigured-gha-job
branch
from
September 6, 2024 11:08
3ffa95f
to
62e7ec3
Compare
Can drop this after rebase on commit f0451bb, first released in 7.0.0
It was broken properly, with a bug in test, after commit c296882 Can drop this after rebase on commit e8cc39e "Fix like regex escaping (apache#1085)", first released in 7.0.0
Can drop this after rebase on commit fc04931 "Make rand an optional dependency (apache#674)", first released in 6.0.0
mcheshkov
force-pushed
the
revive-ci-after-misconfigured-gha-job
branch
from
September 6, 2024 11:31
62e7ec3
to
15aaad5
Compare
srh
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is was broken in commit 6505f1b. GHA does not allow empty vector in build matrix, and does not start whole workflow, not just a single broken job
It would just say
The workflow is not valid. .github/workflows/rust.yml (Line: 129, Col: 15): Matrix vector 'rust' does not contain any values
Like here: https://github.com/cube-js/arrow-rs/actions/runs/10713316185