Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS stamp #23

Open
wants to merge 112 commits into
base: position-hold
Choose a base branch
from

Conversation

ledvinap
Copy link

@ledvinap ledvinap commented Nov 8, 2024

No description provided.

use wasThrottleRaised in place of isAirmodeActivated where airmode isn't really needed
if poshold deadband is zero, sticks are ignored
if user tries to enable posHold and it can't work, they get stick with a deadband
fixes a bug in the last commit, also
Slightly more typingm, but it removes magical dependence on
newGPSData (it is not obvious when is it cleared)
@ctzsnooze
Copy link
Owner

thank you @ledvinap - I'm grateful for this PR.

I did try your original suggestion but couldn't make it work. When I am home again (couple of days) and can test fly it, I'll add these changes to the PR.

@ctzsnooze ctzsnooze force-pushed the position-hold branch 2 times, most recently from d51bad6 to 43efe59 Compare November 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants