forked from betaflight/betaflight
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPS stamp #23
Open
ledvinap
wants to merge
112
commits into
ctzsnooze:position-hold
Choose a base branch
from
ledvinap:ctzsnooze-position-hold
base: position-hold
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GPS stamp #23
ledvinap
wants to merge
112
commits into
ctzsnooze:position-hold
from
ledvinap:ctzsnooze-position-hold
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use wasThrottleRaised in place of isAirmodeActivated where airmode isn't really needed
if poshold deadband is zero, sticks are ignored if user tries to enable posHold and it can't work, they get stick with a deadband
fixes a bug in the last commit, also
Slightly more typingm, but it removes magical dependence on newGPSData (it is not obvious when is it cleared)
thank you @ledvinap - I'm grateful for this PR. I did try your original suggestion but couldn't make it work. When I am home again (couple of days) and can test fly it, I'll add these changes to the PR. |
ctzsnooze
force-pushed
the
position-hold
branch
2 times, most recently
from
November 17, 2024 21:34
d51bad6
to
43efe59
Compare
ctzsnooze
force-pushed
the
position-hold
branch
from
November 26, 2024 20:44
60ca012
to
070e80f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.