Reject reason complete [B: 1647] #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts-ctrlo
commented
Dec 2, 2024
droberts-ctrlo
changed the title
abeverley
reviewed
Dec 5, 2024
|
Thanks Dave, this broadly looks fine, pending UX testing. There are a few formatting issues (e.g. tabs should be 4 spaces, curly brackets on new line) |
Had to add `onNext` and `onBack` overrides to modal class in order to maintain functionality
|
UX Review complete - ready for code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit contained "odd" changes due to merge of current dev branch - this is taken from the current dev branch (post v2.5.11).