View filter changes #267
Closed
View filter changes #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I wasted a day on this when I didn't have to - just noticed we have a JQuery typeahead tool that I could have used when looking through the package.json this morning. I'm thinking of closing this one, and creating a new one using the aforementioned package (as well as chalking this up to a learning experience). If you're "happy" with that, let me know and close this pull. 😄 |
|
I've redone using the inbuilt controls - appears to work as expected this time. Let me know if you have any thoughts on the matter. :happy: |
* Changed dropdown for users to searchable units * API changes * Re-run using correct controls! * Add PDF reporting functionality * Add PDF reporting functionality (#1) * Rebuild JS * Bump JS version * Fix for user editing not working correctly * Latest Version (#2) * Rebuild JS * Bump JS version * Fix for user editing not working correctly --------- Co-authored-by: Andy Beverley <[email protected]> * Working on API route * Fix users able to view forbidden fields in reports (SECURITY FIX) * API Changes done Need to work towards "common" fields working on all searches (i.e. ID, date created, etc.) * JS Working Code * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS * Current UIUX (#4) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Current UIUX (#4) (#5) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Move report generation into standard record route * Fix chronology showing fields that user does not have access to * Add clarification comments * Add option to limit field retrieval by permission * Fix subroutine exit via next * Fix compilation errors * Removed odd code * Reverted changes to JS to work in other solution * Typeahead work * Reporting fixes (ctrlo#277) - Added delete modal - Moved create report button to different place for consistency with other views - Changed the button from Reports to Download options when viewing records - Fixed overflow displaying off edge of screen for long report names - Removed ability to view/edit deleted reports - Fixed error on button code - Removed extra unneeded code - Created utility class for functions that are being used across a number of features (this could have been another request, but I keep having to make this file with most of what I'm doing every time, so it's better to push it now in my opinion) * Minor formatting updates * Revert incorrect code change * Make user fields searchable * Fix for region and org editing error (ctrlo#278) * Add notes field for field configuration * Adding notes field * Typeaheadupgrade (#9) * Current UIUX (#4) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Removed odd code * Reporting fixes (ctrlo#277) - Added delete modal - Moved create report button to different place for consistency with other views - Changed the button from Reports to Download options when viewing records - Fixed overflow displaying off edge of screen for long report names - Removed ability to view/edit deleted reports - Fixed error on button code - Removed extra unneeded code - Created utility class for functions that are being used across a number of features (this could have been another request, but I keep having to make this file with most of what I'm doing every time, so it's better to push it now in my opinion) * Minor formatting updates * Revert incorrect code change * Make user fields searchable * Fix for region and org editing error (ctrlo#278) * Add notes field for field configuration * Adding notes field * Typeahead work * Typeahead complete Created "Builder" class and refactored code out into separate files * Package changes * Typeahead upgrade - Changed currently used typeahead library for one with better documentation (that is also more current) - Retrofitted to areas where old typeahead was used - Created abstraction for use within system - Typeahead class created - TypeaheadOptions interface created - TypeaheadBuilder class created Abstraction was done in order to make code easier to read and the possibility of controlling typeaheads as a single unit (thus keeping behaviour consistent). The builder was placed in order to make construction of a typeahead more verbose in order to mitigate errors within the configuration. * Update validation.js --------- Co-authored-by: Andy Beverley <[email protected]> * Working towards DT typeahead * Changes to API and typeahead - need to work on styling * Typeahead complete on headers * Should now match original UIUX * Further resets --------- Co-authored-by: Andy Beverley <[email protected]>
* Changed dropdown for users to searchable units * API changes * Re-run using correct controls! * Add PDF reporting functionality * Add PDF reporting functionality (#1) * Rebuild JS * Bump JS version * Fix for user editing not working correctly * Latest Version (#2) * Rebuild JS * Bump JS version * Fix for user editing not working correctly --------- Co-authored-by: Andy Beverley <[email protected]> * Working on API route * Fix users able to view forbidden fields in reports (SECURITY FIX) * API Changes done Need to work towards "common" fields working on all searches (i.e. ID, date created, etc.) * JS Working Code * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS * Current UIUX (#4) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Current UIUX (#4) (#5) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Move report generation into standard record route * Fix chronology showing fields that user does not have access to * Add clarification comments * Add option to limit field retrieval by permission * Fix subroutine exit via next * Fix compilation errors * Removed odd code * Reverted changes to JS to work in other solution * Typeahead work * Reporting fixes (ctrlo#277) - Added delete modal - Moved create report button to different place for consistency with other views - Changed the button from Reports to Download options when viewing records - Fixed overflow displaying off edge of screen for long report names - Removed ability to view/edit deleted reports - Fixed error on button code - Removed extra unneeded code - Created utility class for functions that are being used across a number of features (this could have been another request, but I keep having to make this file with most of what I'm doing every time, so it's better to push it now in my opinion) * Minor formatting updates * Revert incorrect code change * Make user fields searchable * Fix for region and org editing error (ctrlo#278) * Add notes field for field configuration * Adding notes field * Typeahead work * Typeahead complete Created "Builder" class and refactored code out into separate files * Package changes * Typeahead upgrade - Changed currently used typeahead library for one with better documentation (that is also more current) - Retrofitted to areas where old typeahead was used - Created abstraction for use within system - Typeahead class created - TypeaheadOptions interface created - TypeaheadBuilder class created Abstraction was done in order to make code easier to read and the possibility of controlling typeaheads as a single unit (thus keeping behaviour consistent). The builder was placed in order to make construction of a typeahead more verbose in order to mitigate errors within the configuration. * Update validation.js --------- Co-authored-by: Andy Beverley <[email protected]>
|
I'm going to start this again with the new typeahead library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.