-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unittests #258
Merged
Merged
Adding unittests #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to add Report table
Edit user updates (#248)
Still need to add other files and entries as per user changes as noted in email from Andy previously
Worked out field display wasn't working because I was being dumb - will now work on displaying ID, User and Created By fields correctly.
Add endpoint created - need to work on how and what to include in the edit (checkboxes to view all fields in table) Possibly see about moving common code into parent sub.
It was decided the permission to view PDF would be enough for all reports rather than just allowing for the user to create reports for specific groups (Discussion with JH - 23/10/23) Files do not contain "fixes" as required for schema generation - will add when stage complete and schema finalised.
Also fixed minor typo within Markdown component definition in site.js
Have added "required" attribute to allow for adding of asterisk
Purely staging in order to ensure all file changes are backed up.
Have made unit testing work - "test" folder contains stubs or full implementations for use within testing (as babel is used and doesn't "like" certain paths because of exclusion rules, causing tests to fail) - will explain if required in face-to-face meeting this week with AB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be correct and not contain the merge I made for reporting unit testing