Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unittests #258

Merged
merged 26 commits into from
Oct 26, 2023
Merged

Adding unittests #258

merged 26 commits into from
Oct 26, 2023

Conversation

droberts-ctrlo
Copy link
Contributor

This should be correct and not contain the merge I made for reporting unit testing

droberts-ctrlo and others added 26 commits October 17, 2023 13:32
Updated to add Report table
Still need to add other files and entries as per user changes as noted in email from Andy previously
Worked out field display wasn't working because I was being dumb - will now work on displaying ID, User and Created By fields correctly.
Add endpoint created - need to work on how and what to include in the edit (checkboxes to view all fields in table)

Possibly see about moving common code into parent sub.
It was decided the permission to view PDF would be enough for all reports rather than just allowing for the user to create reports for specific groups (Discussion with JH - 23/10/23)

Files do not contain "fixes" as required for schema generation - will add when stage complete and schema finalised.
Also fixed minor typo within Markdown component definition in site.js
Have added "required" attribute to allow for adding of asterisk
Purely staging in order to ensure all file changes are backed up.
Have made unit testing work - "test" folder contains stubs or full implementations for use within testing (as babel is used and doesn't "like" certain paths because of exclusion rules, causing tests to fail) - will explain if required in face-to-face meeting this week with AB
@abeverley abeverley merged commit 7d386dc into ctrlo:uiux Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants