Modal dismiss on key #242
Merged
Modal dismiss on key #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a horrible fix, but it's the only way I could make it work!
…/gads into modalDismissOnKey
abeverley
reviewed
Oct 11, 2023
| const $form = $button.closest("form") | ||
| const $requiredHiddenRecordDependentFields = $form.find(".form-group[data-has-dependency='1'][style*='display: none'] *[aria-required]") | ||
| //This is awful, but if I use a find on all parents to find the .modal-body, the "normal" submit button crashes the browser with an (almost) infinite loop | ||
| const $parent = $button.parent().parent().parent().parent().parent().parent().parent().parent().parent().parent().parent(); |
There was a problem hiding this comment.
See if you can get this working with a closest()
|
Please also see if you can make this generic to also work on the main record. |
Some logging is used within the code for errors etc. - these have been kept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a horrible fix, but it's the only way I could make it work!
Walks up the tree to see if the button is in a modal, if it is, it calls submit directly, if not, it doesn't.
If you use
$button.parents().find('.modal-body')it will find the modal if the button is in a modal, but if it isn't, it enters a loop that crashes the browser while looking for the element.