Uiux #235
Merged
Uiux #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'space' and 'enter' key-down functionality for the record pop-ups
Added a Stopprop to popover so it no longer bubbles up to the record pop-over. Then added keyboard functionality and disabled default behaviour. As I was finding that the default button click (via keyboard) was being over-ridden by other events with specified key-down functionality.
I was finding that the default keyboard click no longer worked when there was a parent element with a key-down event. So resolved the issue by removing the default behaviour of this click event and replacing it with it's own specified keyboard functionality.
|
Thanks Oliver, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Keyboard functionality to the record-popup and the 2 different popover events that can be found within a record-popup table row.
Then by disabling defaults and adding Stop-propagation to the popover's event, it will stop any bubbling or keydown events interfering between the popovers and the record-popup they are nested in.