Patch 1 #233
Closed
Patch 1 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that the curval pop-overs were not selectable with keyboards, so added the option trigger event with space or enter in addition to the standard click. Also added check to make sure current target isn't a button. As selecting buttons within the row (via keyboard) were also triggering this event by mistake.
Noticed that the curval pop-overs were not selectable with keyboards, so added the option trigger event with space or enter in addition to the standard click. Also added check to make sure current target isn't a button. As selecting buttons within the row (via keyboard) were also triggering this event by mistake.
Made required input * red so it stands out more
|
Thanks Oliver, great work. Keyboard functionality is great, I am happy to merge. I'm not sure about the mandatory symbol in red (sorry, I was going to add a comment to the issue a while ago) - I'll discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added keyboard functionality to the pop-over records, so rather than being just on-click pop-ups can be displayed using space or enter as-well.
Made the mandatory symbol (*) red so it stands out more.