Warning for ties in stats #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print a message if there are ties in the metric and the percentage of it. This only for metric not equal to zero, as random order of genes equal to 0 it is no relevant. No idea which percentage of ties are aceptable, nor if it is relevant for the biological interpretation of the results. But the user should be aware of this when they are doing the analysis. As discussed in #18 and #19
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 93.52% 93.54% +0.02%
==========================================
Files 5 5
Lines 710 713 +3
==========================================
+ Hits 664 667 +3
Misses 46 46
Continue to review full report at Codecov.
|
|
Good point about ties for zero ranks! Could you add a test for these cases? |
|
Sorry, I do not get what you mean with a test for the zero rank cases. |
|
I mean, adding |
Testthat test for "Ties detection in ranking works"
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a message if there are ties in the metric and the percentage of it.
@assaron,
Due to the previous discussion about ties (#18) and never ending analysis (#19), I put some changes to include a warning for the presence of ties in the stats:
Best,
ToledoEM