Remove ctfd_challenge subresources (files/flags/hints)

[pandatix]

The current design of the ctfd_challenge, despite it proposes a unified API to manage a CTFd challenge, has many problem.
One of them is that internally, a lot of work has to be performed to follow the deltas and the CRUD operations necessary to cope with the Terraform plan.
For many reasons (and especially both a burden of maintainability and poor configuration quality) we must step back from the goal of a unified API.

This PR:

• splits ctfd_challenge.file attribute to its own resource ctfd_file, along with lifecycle tests
• splits ctfd_challenge.flag attribute to its own resource ctfd_flag, along with lifecycle tests
• splits ctfd_challenge.hint attribute to its own resource ctfd_hint, along with lifecycle tests. Permit hints to be depends on one another 🎉
• fix inconsistencies with the ctfd_challenge.decay, ctfd_challenge.minimum, ctfd_challenge.tags and ctfd_challenge.topics attributes empty/default values.

Follows an example of what this PR technically implies for end users.

Before

resource "ctfd_challenge" "http" {
  name        = "My Challenge"
  category    = "misc"
  description = "..."
  value       = 500
  decay       = 100
  minimum     = 50
  state       = "visible"
  function    = "logarithmic"

  flags = [{
    content = "CTF{some_flag}"
  }]

  topics = [
    "Misc"
  ]
  tags = [
    "misc",
    "basic"
  ]

  hints = [{
    content = "Some super-helpful hint"
    cost    = 50
    }, {
    content = "Even more helpful hint !"
    cost    = 50
  }]

  files = [{
    name       = "image.png"
    contentb64 = filebase64(".../image.png")
  }]
}

After

resource "ctfd_challenge" "http" {
  name        = "My Challenge"
  category    = "misc"
  description = "..."
  value       = 500
  decay       = 100
  minimum     = 50
  state       = "visible"
  function    = "logarithmic"

  topics = [
    "Misc"
  ]
  tags = [
    "misc",
    "basic"
  ]
}

resource "ctfd_flag" "http_flag" {
  challenge_id = ctfd_challenge.http.id
  content = "CTF{some_flag}"
}

resource "ctfd_hint" "http_hint_1" {
  challenge_id = ctfd_challenge.http.id
  content = "Some super-helpful hint"
  cost = 50
}

resource "ctfd_hint" "http_hint_2" {
  challenge_id = ctfd_challenge.http.id
  content = "Even more helpful hint !"
  cost = 50
  requirements = [ctfd_hint.http_hint_1.id]
}

resource "ctfd_file" "http_file" {
  challenge_id = ctfd_challenge.http.id
  name = "image.png"
  contentb64 = filebase64(".../image.png")
}

Documentation has been updated and make docs run.

Due to breaking changes, this PR implies for the next release to be major.

[coveralls]

Pull Request Test Coverage Report for Build 9340694681

Details

• 478 of 681 (70.19%) changed or added relevant lines in 8 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-1.2%) to 70.169%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
provider/challenge_data_source.go	0	4	0.0%
provider/challenge_resource.go	78	108	72.22%
provider/flag_resource.go	119	160	74.38%
provider/file_resource.go	160	222	72.07%
provider/hint_resource.go	108	174	62.07%

Files with Coverage Reduction	New Missed Lines	%
provider/challenge_resource.go	2	74.63%

Totals
Change from base Build 9330859307:	-1.2%
Covered Lines:	1456
Relevant Lines:	2075

---

💛 - Coveralls

[NicoFgrx]

Nice job !

pouet is not just a cat, it's a philosophy