Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images publishing: SLSA 3 and SBOMs #71

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

pandatix
Copy link
Member

In this PR I propose to remove the role of building and publishing Docker images from goreleaser. The reasoning is that we need to propagate metadata manually, and whatever we do, we cannot easily produce SBOMs and sign the images.

Due to this limitation, and the necessity to achieve SLSA 3 on a Kubernetes cluster through Kyverno for CTFer.io clusters, we need this PR.
On everyday's life of the asset, those security features won't be used but it does not interfere with the functionalities.

@pandatix pandatix added enhancement New feature or request security When there are security related info labels Oct 29, 2024
@pandatix pandatix requested a review from NicoFgrx October 29, 2024 17:40
Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit 423c99a into main Oct 29, 2024
8 checks passed
@pandatix pandatix deleted the security/slsa3-sbom branch October 29, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security When there are security related info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants