Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude lst1 dl1 merged #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Exclude lst1 dl1 merged #129

wants to merge 2 commits into from

Conversation

aleberti
Copy link
Collaborator

@aleberti aleberti commented Dec 5, 2022

Closes #128.

@aleberti
Copy link
Collaborator Author

aleberti commented Dec 5, 2022

I checked that the script exits if run over a DL1 merged files, while it will run as before for subrun files.

YoshikiOhtani
YoshikiOhtani reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@YoshikiOhtani YoshikiOhtani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alessio, thanks for the implementation, and it looks fine to me. One small suggestion is to put the code inside the event_coincidence function for a safe side, so that it also stops when one directly executes it.

@YoshikiOhtani
Copy link
Collaborator

Yukiho started the MAGIC-LST analysis and encountered the same problem. I think we should merge it, as my comments are very minor one. Do you agree, @aleberti?

@YoshikiOhtani YoshikiOhtani self-requested a review June 16, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshikiOhtani YoshikiOhtani YoshikiOhtani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory issues when running event coincidence on merged LST-1 DL1 files
2 participants
@aleberti @YoshikiOhtani