Application of Cat-B calibration (option1) #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Morcuende <[email protected]>
morcuended
reviewed
Oct 15, 2024
| log.info(f"Going to level {level}") | ||
| else: | ||
| level -= 2 | ||
| log.info(f"No images stored in dl1ab. Producing DL2. Going to level {level}") |
There was a problem hiding this comment.
Suggested change
| log.info(f"No images stored in dl1ab. Producing DL2. Going to level {level}") | |
| log.info( | |
| f"No images stored in dl1ab. Skipping datachecks and producing DL2. Going to level {level}" | |
| ) |
Comment on lines
+192
to
+202
| if run_str[-4:] != "0000": | ||
| log.debug(f"{run_str} is not the first subrun of the run, so the script " | ||
| "onsite_create_cat_B_calibration_file will not be launched for this subrun.") | ||
|
|
||
| catB_calibration_file = get_catB_calibration_filename(int(run_str[:5])) | ||
| n = 0 | ||
| n_max = 10 | ||
| while not catB_calibration_file.exists() and n<=n_max: | ||
| time.sleep(120) | ||
| n += 1 | ||
| return 0 |
There was a problem hiding this comment.
Do you need the sleep part here if you plan to do it in two steps?
Comment on lines
+193
to
+202
| log.debug(f"{run_str} is not the first subrun of the run, so the script " | ||
| "onsite_create_cat_B_calibration_file will not be launched for this subrun.") | ||
|
|
||
| catB_calibration_file = get_catB_calibration_filename(int(run_str[:5])) | ||
| n = 0 | ||
| n_max = 10 | ||
| while not catB_calibration_file.exists() and n<=n_max: | ||
| time.sleep(120) | ||
| n += 1 | ||
| return 0 |
There was a problem hiding this comment.
I think I'd simply return if subrun is not 0
Comment on lines
+224
to
+225
| #elif program == cfg.get("lstchain", "catB_calibration"): | ||
| # level = 3 if exit_status == 0 else 4 |
There was a problem hiding this comment.
why is it commented? do you plan to include a new cat B calibration line in the history file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to process some nights "fast" with Cat-B calibration we have thought of this option. The idea is to launch first a sequencer with option --no-dl1ab, then the script onsite_create_cat_B_calibration "manually" and then another sequencer (without option --no-dl1ab). I have created a script that does all these steps by its own and it seems to be working. Tests are ongoing.