Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new production src5 with lstchain v0.10 #412

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

alvmas
Copy link
Contributor

@alvmas alvmas commented Aug 29, 2023

20230829_src5_dec3476_v0.10_tuned

New Prod config

Self check-list:

  • I have checked the lstchain config, in particular for:
    • az_tel instead of sin_az_tel if data to be analyzed have been produced with lstchain <= v0.9.7
    • "increase_nsb" and "increase_psf" are provided in "image_modifier" (if used)
  • I have checked the environment in the lstmcpipe config and it is the one used to analyse DL>1 data
  • I have provided the command (in README), or script (in additionnal .py file) used to produce the lstmcpipe config

Prod_ID

Short description of the config

Why this config is needed

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.28% 🎉

Comparison is base (ed95d37) 30.62% compared to head (b5a9962) 31.90%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   30.62%   31.90%   +1.28%     
==========================================
  Files          46       46              
  Lines        2779     2830      +51     
==========================================
+ Hits          851      903      +52     
+ Misses       1928     1927       -1     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuillaut
Copy link
Member

vuillaut commented Aug 29, 2023

Hi @alvmas
Your lstchain config seems wrong with a missing coma:

json.decoder.JSONDecodeError: Expecting ',' delimiter: line 318 column 5 (char 8667)

@alvmas
Copy link
Contributor Author

alvmas commented Aug 29, 2023

Hi, I corrected the config file but it seems to be failing the PR as well.

@vuillaut
Copy link
Member

Hi, I corrected the config file but it seems to be failing the PR as well.

this was a fluke, thanks for fixing the config, tests are now passing, I will launch the prod

@vuillaut vuillaut merged commit b34d14e into cta-observatory:master Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants