-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PSF work with nd-input #2689
Draft
maxnoe
wants to merge
70
commits into
PSFModel
Choose a base branch
from
psf_model_fixes
base: PSFModel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sphinx-changelog
Fix uncertainty calculation in StereoMeanCombiner
Fix error in ctapipe-process in case telescope event is missing true image
Fix tool exit order
Prepare 0.23.1
Fix sonar for pull requests
Fix broken Numpy style guide link.
Current link is broken showing "no status" message
Update the link to the CI status badge in README
Add explicit cast necessary in numpy >=2.1
Co-authored-by: Daniel Morcuende <[email protected]> Co-authored-by: Daniel Morcuende <[email protected]>
Prepare 0.23.2
Fill `containers.SimulatedCameraContainer.true_image_sum` in HDF5eventsource
Make sonar coverage badge link point to coverage
I checked, the result is the same in #2643 when using loops to evaluate single points, so the vectorization here is correct and the results are weird. |
@mexanick I pushed some changes to notation and fixed the order of paramters to Still not what I would expect... but no nans is an improvement I'd say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make #2643 work with ND input.
Using this script to plot:
This is the current result on this branch (The PSF at (1, 1) all evaluates to nan_: