Add CI run running on oldest supported versions of core dependencies #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
oldest_deps
branch
3 times, most recently
from
d497789 to
71a2b27
Compare
maxnoe
changed the title
This comment has been minimized.
This comment has been minimized.
kosack
previously approved these changes
Sep 13, 2024
Tobychev
previously approved these changes
Sep 19, 2024
Tobychev
reviewed
Jan 24, 2025
.github/workflows/ci.yml
Outdated
| - if: contains(matrix.extra-args, 'oldest-deps') && contains(github.event.pull_request.labels.*.name, 'documentation-only') == false | ||
| run: | | ||
| micromamba install -n cta-dev -y numpy=1.24 numba=0.57 scipy=1.10 astropy=5.3 matplotlib=3.6 |
There was a problem hiding this comment.
Is there really no other way than hardcoding the version numbers in the ci.yml config file? Seems easy to have it get out of synch, but may that doesn't lead to any hard to solve problems?
There was a problem hiding this comment.
I didn't find an elegant solution to this. astropy for example also hard-codes their oldest supported versions (in tox.ini in this case):
https://github.com/astropy/astropy/blob/fc2ef61cf6dbb3a06a5e9d11c19995960902e63b/tox.ini#L76-L90
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.