Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[modules,root]: concise GCP and terraform modules #9

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

sydrawat01
Copy link
Member

  • Introduced folders module that will create a folder within the specified folder
  • Moved vpc module to network module with minor bug fixes
  • The projects module now creates projects within the folder created by the folders module
  • Added timeouts to GCP API services
  • Fixed vm network interface bug
  • Updated & refactored the modules and variables in the root module

Fixes issues #3 #4

- Introduced `folders` module that will create a folder within the
specified folder
- Moved `vpc` module to `network` module with minor bug fixes
- The `projects` module now creates  projects within the folder created
by the `folders` module
- Added timeouts to GCP API services
- Fixed `vm` network interface bug
- Updated & refactored the modules and variables in the `root` module

Fixes issues #3 #4
@sydrawat01
Copy link
Member Author

This PR will be moved from draft to ready for review once the documentation is ready for #2

- Added steps to install GCP CLI and HCP Terraform
- Added GCP organization setup steps to configure GCP CLI and service
accounts

Fixes issue #2
@sydrawat01 sydrawat01 temporarily deployed to karan October 5, 2023 15:29 — with GitHub Actions Inactive
@sydrawat01 sydrawat01 linked an issue Oct 5, 2023 that may be closed by this pull request
@sydrawat01 sydrawat01 marked this pull request as ready for review October 5, 2023 15:30
@sydrawat01 sydrawat01 requested a review from rishabNeu October 5, 2023 15:31
Copy link
Member

@rishabNeu rishabNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just uncomment that firewall ssh rule: target tags

@rishabNeu rishabNeu merged commit 88d432d into csye7125-fall2023-group05:master Oct 5, 2023
1 check passed
@rishabNeu rishabNeu deleted the feat-0.0 branch October 5, 2023 16:22
@sydrawat01
Copy link
Member Author

lgtm just uncomment that firewall ssh rule: target tags

This will be handled in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants