fix: update os_login public ssh key to be loaded dynamically

README.md

@@ -229,6 +229,8 @@ resource "google_compute_instance" "vm" {
 
 To generate the ssh key locally on your workstation, use the following command:
 
+> NOTE: It is recommended that you create and store the SSH keys in `~/.ssh` directory
+
 ```bash
 # follow the on-screen steps after running the command
 # avoid adding a passphrase
@@ -242,6 +244,7 @@ Use the below command to connect to the instance:
 ssh -i <path-to-private-key> <username>@<external-ip>
 # if os login is enabled:
 ssh -i <path-to-private-key> <USERNAME_DOMAIN_SUFFIX>@<external-ip>
+# example: ssh -i ~/.ssh/gcp-compute.pub [email protected]
 ```
 
 ### 🕹️ Enabling APIs

modules/os_login/main.tf

@@ -4,7 +4,7 @@ data "google_client_openid_userinfo" "me" {}
 # Add public ssh key to IAM user
 resource "google_os_login_ssh_public_key" "cache" {
   user = data.google_client_openid_userinfo.me.email
-  key  = file("~/.ssh/gcp-compute.pub")
+  key  = file("~/.ssh/${var.ssh_key_file}")
 }
 
 # Allow IAM user to use OS Login

modules/os_login/variables.tf

@@ -1 +1,2 @@
 variable "project_id" {}
+variable "ssh_key_file" {}

root/example.tfvars

@@ -12,3 +12,4 @@ subnet_name        = ""
 vm_name            = ""
 machine_type       = ""
 zone               = ""
+ssh_key_file       = ""

root/main.tf

@@ -67,7 +67,8 @@ resource "time_sleep" "creating_vm" {
 }
 
 module "os_login" {
-  depends_on = [time_sleep.creating_vm]
-  source     = "../modules/os_login"
-  project_id = var.project_id
+  depends_on   = [time_sleep.creating_vm]
+  source       = "../modules/os_login"
+  project_id   = var.project_id
+  ssh_key_file = var.ssh_key_file
 }

root/variables.tf

@@ -73,3 +73,8 @@ variable "zone" {
   type        = string
   description = "Zone name"
 }
+
+variable "ssh_key_file" {
+  type        = string
+  description = "Public ssh key file (<filename>.pub)"
+}