Retroactive union find #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay here! I've realized recently that I've not been getting the GitHub notifications that I've wanted to get, so I just saw this. At a glance, this looks really really nice! I appreciate the tests, and it fits well into the rest of the codebase. I'll go through in more depth and give it a proper code review soon. Thanks for writing this! |
|
No worries. Thanks for creating the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this project was pretty cool, so I took a stab at implementing fully retroactive union find using link cut trees as the backing data structure.
The semantics for updating and querying use time deltas to specify time, similar to the existing tminus semantics. The only difference is that is supports operations in the future as well as the past. You can find an example usage in examples.py